chore: update toggle-devmode to use flatpak brewfiles #100
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the toggle-devmode and install-system-flatpaks recipes. The changes transition from rpm-ostree to bootc for image switching and adopt Homebrew Brewfiles for managing Flatpak installations, which is a good improvement. However, I've found a couple of issues in the shell scripting: an unquoted variable that could cause issues with image names containing special characters, and a reused variable name that introduces a logical bug in the Flatpak installation logic. Addressing these will improve the robustness of the scripts.
inffy
requested review from
NiHaiden,
hanthor,
ledif and
renner0e
as code owners
| esac | ||
|
|
||
| flatpak remote-add --if-not-exists --system flathub https://flathub.org/repo/flathub.flatpakrepo | ||
| # Disable Fedora Flatpak remotes |
There was a problem hiding this comment.
did you intend to delete this?
There was a problem hiding this comment.
kind of, I just aligned with bluefins and i think they never had this part.
There was a problem hiding this comment.
I guess it's fine to remove, we should probably add the fedora flaptak stuff to the alternate installation guide then, so we at least can point to somewhere.
3 participants
Needs #97